[Differential] [Commented On] D2199: Prepare for LLDB plugin: Move Disassemble/Registers toolview into common

[qi437103 (Aetf)]

qi437103 added a comment.


  IMHO, common is just a library that can be used by either GDB or LLDB, and with default settings working out-of-box for GDB. If GDB or LLDB plugin wants different behavior, it could subclass and change it. And it's the GDB or LLDB plugin's responsibility to test whether common works as expected.
  
  Also, technically, you can't just simply test common without pulling in GDB or LLDB specific code, as common itself isn't a complete plugin and isn't associated with any debugger. While it's possible to test it by adding extra mock objects and use either/both GDB and LLDB as backend, I feel it's simpler to just test it in either GDB or LLDB code.

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D2199

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: qi437103, #kdevelop, apol
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160719/258c8776/attachment.html>