[Differential] [Commented On] D2192: Move implementation of hasError and setHasError to iplugin

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  I'm not sure why you did it though...? Isn't it largely a matter of taste?
  
  Where's the `errorDescription` being used?

INLINE COMMENTS

> iplugin.cpp:198
> +
> +void KDevelop::IPlugin::setErrorDescription(const QString& description)
> +{

Would it make sense to limit the hasError to whether there's an errorDescription? The only advantage otherwise is to be able to have a failing plugin without a message.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2192

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: volden, #kdevelop
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160716/882a06e8/attachment-0001.html>