[Differential] [Commented On] D1947: Use folder prefix is filename is not unique

[brauch (Sven Brauch)]

brauch added a comment.


  rest looks good to me, thanks :)

INLINE COMMENTS

> container.cpp:165
> +            ) {
> +                auto url = qobject_cast<Sublime::UrlDocument*>(view->document())->url().toString();
> +                int secondOffset = url.lastIndexOf('/');

add a null check here

> container.cpp:420
>              Q_ASSERT(d->documentListActionForView.contains(view));
> -            d->documentListActionForView[view]->setText(doc->title());
> +            if (!d->documentListActionForView[view]->text().endsWith('/' + doc->title())) {
> +                d->documentListActionForView[view]->setText(doc->title());

But what it if it really changed, e.g. "save as", does that work?

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D1947

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cordlandwehr, #kdevelop
Cc: brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160703/78327056/attachment.html>