<table><tr><td style="">brauch added a comment.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1947" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>rest looks good to me, thanks :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1947#inline-8064" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">container.cpp:165</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #aa4000">auto</span> <span class="n">url</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">Sublime</span><span style="color: #aa2211">::</span><span class="n">UrlDocument</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">view</span><span style="color: #aa2211">-></span><span class="n">document</span><span class="p">())</span><span style="color: #aa2211">-></span><span class="n">url</span><span class="p">().</span><span class="n">toString</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #aa4000">int</span> <span class="n">secondOffset</span> <span style="color: #aa2211">=</span> <span class="n">url</span><span class="p">.</span><span class="n">lastIndexOf</span><span class="p">(</span><span style="color: #766510">'/'</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">add a null check here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1947#inline-8065" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">container.cpp:420</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">Q_ASSERT</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">documentListActionForView</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">view</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">documentListActionForView</span><span class="p">[</span><span class="n">view</span><span class="p">]</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">().</span><span class="n">endsWith</span><span class="p">(</span><span style="color: #766510">'/'</span> <span style="color: #aa2211">+</span> <span class="n">doc</span><span style="color: #aa2211">-></span><span class="n">title</span><span class="p">()))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">documentListActionForView</span><span class="p">[</span><span class="n">view</span><span class="p">]</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">doc</span><span style="color: #aa2211">-></span><span class="n">title</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">But what it if it really changed, e.g. "save as", does that work?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEVPLATFORM KDevPlatform</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1947" rel="noreferrer">https://phabricator.kde.org/D1947</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>cordlandwehr, KDevelop<br /><strong>Cc: </strong>brauch, kdevelop-devel<br /></div>