Review Request 126889: Patch to remove/implement "TODO"

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126889/#review91613
-----------------------------------------------------------



Did you test whether this test succeeds with both the old and the new implementation?

And: Nice to see you're working on this, Pedro!


languages/clang/tests/test_clangutils.h (line 36)
<https://git.reviewboard.kde.org/r/126889/#comment62602>

    Rename this, too, when you rename the function-under-test.



languages/clang/tests/test_clangutils.cpp (line 180)
<https://git.reviewboard.kde.org/r/126889/#comment62601>

    Rename to `expectedTypes`



languages/clang/tests/test_clangutils.cpp (line 186)
<https://git.reviewboard.kde.org/r/126889/#comment62605>

    Rename to `types`



languages/clang/tests/test_clangutils.cpp (line 218)
<https://git.reviewboard.kde.org/r/126889/#comment62603>

    I'm surprised to see the empty string here at the end(?) -- Why's that?



languages/clang/tests/test_clangutils.cpp (line 230)
<https://git.reviewboard.kde.org/r/126889/#comment62604>

    Dito



languages/clang/util/clangutils.h (line 102)
<https://git.reviewboard.kde.org/r/126889/#comment62600>

    Should probably be renamed to `getTemplateArgumentTypes`



languages/clang/util/clangutils.cpp (line 271)
<https://git.reviewboard.kde.org/r/126889/#comment62599>

    Just: `#if CINDEX_VERSION_MINOR <= 24` (we use the scheme in all other places)


- Kevin Funk


On Jan. 26, 2016, 3:40 p.m., Pedro Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126889/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 3:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This drops a TODO message and inserts a compile-time selector between clang-based template argument parsing and what appears to be manual tokenisation.
> 
> 
> Diffs
> -----
> 
>   languages/clang/codecompletion/completionhelper.cpp c01185a 
>   languages/clang/tests/test_clangutils.h 4508907 
>   languages/clang/tests/test_clangutils.cpp 1a8ecb7 
>   languages/clang/util/clangutils.h e47058e 
>   languages/clang/util/clangutils.cpp 81f7b44 
> 
> Diff: https://git.reviewboard.kde.org/r/126889/diff/
> 
> 
> Testing
> -------
> 
> This is possibly incomplete. It works for me (I'm using a KDev built with this), but would obviously appreciate comments.
> Mind you, the include header in Clang for this function ("clang_Type_getTemplateArgumentAsType") says that this function does not support variadic templates, so potentially this patch is not acceptable.
> 
> 
> Thanks,
> 
> Pedro Ferreira
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160126/53b972f2/attachment-0001.html>