Review Request 126889: Patch to remove/implement "TODO"

[Pedro Ferreira]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126889/
-----------------------------------------------------------

(Updated Jan. 26, 2016, 3:40 p.m.)


Review request for KDevelop.


Changes
-------

Added test cases.


Repository: kdevelop


Description
-------

This drops a TODO message and inserts a compile-time selector between clang-based template argument parsing and what appears to be manual tokenisation.


Diffs (updated)
-----

  languages/clang/codecompletion/completionhelper.cpp c01185a 
  languages/clang/tests/test_clangutils.h 4508907 
  languages/clang/tests/test_clangutils.cpp 1a8ecb7 
  languages/clang/util/clangutils.h e47058e 
  languages/clang/util/clangutils.cpp 81f7b44 

Diff: https://git.reviewboard.kde.org/r/126889/diff/


Testing
-------

This is possibly incomplete. It works for me (I'm using a KDev built with this), but would obviously appreciate comments.
Mind you, the include header in Clang for this function ("clang_Type_getTemplateArgumentAsType") says that this function does not support variadic templates, so potentially this patch is not acceptable.


Thanks,

Pedro Ferreira

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160126/90fc66f1/attachment.html>