Review Request 126889: Patch to remove/implement "TODO"

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126889/#review91610
-----------------------------------------------------------



+1 in principle, but I'd like to see this being properly unit-tested. Could you do that while you touch it please?

Thanks!


languages/clang/codecompletion/completionhelper.cpp (line 58)
<https://git.reviewboard.kde.org/r/126889/#comment62596>

    This function should be moved to util/clangutils.h and a unit test should be added as well. Could you do that please?


- Milian Wolff


On Jan. 26, 2016, 10:35 a.m., Pedro Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126889/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 10:35 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This drops a TODO message and inserts a compile-time selector between clang-based template argument parsing and what appears to be manual tokenisation.
> 
> 
> Diffs
> -----
> 
>   languages/clang/codecompletion/completionhelper.cpp c01185a 
> 
> Diff: https://git.reviewboard.kde.org/r/126889/diff/
> 
> 
> Testing
> -------
> 
> This is possibly incomplete. It works for me (I'm using a KDev built with this), but would obviously appreciate comments.
> Mind you, the include header in Clang for this function ("clang_Type_getTemplateArgumentAsType") says that this function does not support variadic templates, so potentially this patch is not acceptable.
> 
> 
> Thanks,
> 
> Pedro Ferreira
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160126/6c69d078/attachment.html>