Review Request 126889: Patch to remove/implement "TODO"

[Pedro Ferreira]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126889/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdevelop


Description
-------

This drops a TODO message and inserts a compile-time selector between clang-based template argument parsing and what appears to be manual tokenisation.


Diffs
-----

  languages/clang/codecompletion/completionhelper.cpp c01185a 

Diff: https://git.reviewboard.kde.org/r/126889/diff/


Testing
-------

This is possibly incomplete. It works for me (I'm using a KDev built with this), but would obviously appreciate comments.
Mind you, the include header in Clang for this function ("clang_Type_getTemplateArgumentAsType") says that this function does not support variadic templates, so potentially this patch is not acceptable.


Thanks,

Pedro Ferreira

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160126/4a4bb76a/attachment.html>