Review Request 125664: bug 327760. user will be notified if the debug symbols are missing

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125664/#review91532
-----------------------------------------------------------




debuggers/gdb/gdb.h (line 143)
<https://git.reviewboard.kde.org/r/125664/#comment62535>

    this should be false, it was not yet reported.



debuggers/gdb/gdb.cpp (line 179)
<https://git.reviewboard.kde.org/r/125664/#comment62536>

    this should check whether it was _not_ yet reported.
    
    also, merge this with the conditional above
    
        if (buffer_.contains("No...") && !reportedMissingSymbolTable) {
            KMessageBox::...
            reportedMissingSymbolTable = true;
        }



debuggers/gdb/gdb.cpp (line 184)
<https://git.reviewboard.kde.org/r/125664/#comment62537>

    and this should set the value to true.


- Milian Wolff


On Jan. 24, 2016, 1:54 p.m., rishabh  gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125664/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2016, 1:54 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez, Kevin Funk, and Milian Wolff.
> 
> 
> Bugs: 327760
>     http://bugs.kde.org/show_bug.cgi?id=327760
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> code will check if the project compiled is complied with debug symbols or not .if it's not compiled with the debug symbols user will be notified about it
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/gdb.h 087f51e 
>   debuggers/gdb/gdb.cpp 66fee9e 
> 
> Diff: https://git.reviewboard.kde.org/r/125664/diff/
> 
> 
> Testing
> -------
> 
> builds 100%
> testing done
> 
> 
> Thanks,
> 
> rishabh  gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160124/b5e7e013/attachment.html>