Review Request 126761: [OS X] handle LaunchServices requests to open files (i.e. from the Finder)

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126761/
-----------------------------------------------------------

(Updated Jan. 18, 2016, 4:46 p.m.)


Review request for KDevelop.


Changes
-------

This new iteration addresses most flagged issues, and introduces support for handling multiple FileOpen events by queuing them. This makes it possible to open several files at once in a single KDevelop instance, when none was already running. I have yet to find a way to achieve the same when multiple sessions are already open; in that case the session selector is displayed for each file to be opened. It seems the only way to avoid this would be to keep track of the time between FileOpen events. Events coming in in very rapid succession are most likely caused by a multiple selection in the Finder; ideally this would probably look at the event creation timestamp, not event reception which could be dependent on application load.

Should I pursue that idea, or is it better to present a session selection dialog for each file of a multiple selection?


Repository: kdevelop


Description
-------

This patch introduces support for file open requests from for instance the Finder, on OS X. It also makes it possible to launch KDevelop from the Finder (or the Dock) with the Command key held, in which case the session picker dialog will be presented if multiple sessions are open.


Diffs (updated)
-----

  app/Info.plist.in be256f9 
  app/main.cpp b5f7bb9 

Diff: https://git.reviewboard.kde.org/r/126761/diff/


Testing
-------

On OS X 10.9.5 with Qt 5.5.1 and KF5 Frameworks 5.17.0 installed in /opt/local


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160118/9fa4c659/attachment.html>