Review Request 126761: [OS X] handle LaunchServices requests to open files (i.e. from the Finder)

[René J.V. Bertin]

> On Jan. 17, 2016, 7:23 p.m., Milian Wolff wrote:
> > app/main.cpp, line 95
> > <https://git.reviewboard.kde.org/r/126761/diff/1/?file=431004#file431004line95>
> >
> >     Apparently the new reviewboard is messing around with you. I'm commenting on the new `processEvents` call in `startFilteringEvents`.

Weird: the line numbers are correct (for `processEvents`), but I'm not seeing the corresponding code in the embedded display. Must be a local setting in my browser that isn't handled too well in the new reviewboard.

As to the `processEvents` call: it's there to be sure that any queued `FileOpen` events are handled immediately. I need to maximise the likelihood that `app.session` gets set to the user's choice before it's used.

I realise now that I never checked what happens when I open multiple files at once (e.g. by dragging multiple file icons onto the app icon).
A more complete implementation that handles such a situation would probably include a state variable that signals to the actual `eventFilter` payload that multiple `FileOpen` events could arrive and that their file URLs should be appended and opened in a single target session. I'll try to find some time to test this idea one of these days.


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126761/#review91223
-----------------------------------------------------------


On Jan. 15, 2016, 4:50 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126761/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 4:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This patch introduces support for file open requests from for instance the Finder, on OS X. It also makes it possible to launch KDevelop from the Finder (or the Dock) with the Command key held, in which case the session picker dialog will be presented if multiple sessions are open.
> 
> 
> Diffs
> -----
> 
>   app/Info.plist.in be256f9 
>   app/main.cpp b5f7bb9 
> 
> Diff: https://git.reviewboard.kde.org/r/126761/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with Qt 5.5.1 and KF5 Frameworks 5.17.0 installed in /opt/local
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160117/929bcd98/attachment.html>