[Differential] [Updated] D817: Some includes and CmakeLists fixed

[kfunk (Kevin Funk)]

kfunk added a comment.

Mostly nitpicks.

Nice work!

I'll let Friedrich do a proper review.


INLINE COMMENTS
  utils/CMakeLists.txt:9 Please remove this line and the indentation after.
  utils/CMakeLists.txt:15 This pulls in KastenCore automatically I assume? -> Then don't specifically search for it.
  utils/CMakeLists.txt:16 Similarly
  utils/CMakeLists.txt:18 Similarly
  utils/CMakeLists.txt:32 Remove
  utils/okteta/CMakeLists.txt:25 Remove
  utils/okteta/CMakeLists.txt:42 Duplicate
  utils/okteta/kdevokteta.json:1 This file should have  proper indentation. Did sth go wrong with `desktoptojson`?
  utils/okteta/oktetadocument.cpp:213 Fix indent
  utils/okteta/oktetadocument.cpp:235 Nitpick: Use new-style connect
  utils/okteta/oktetaglobal.h:17 As you said: This file should probably be killed?
  utils/okteta/oktetaplugin.cpp:119 `QVariant::fromValue(...)`?

REPOSITORY
  rKDEVELOP KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D817

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apuzio, kossebau, kfunk
Cc: kdevelop-devel