[Differential] [Updated] D583: Fix DUChainUtils::getInheriters.

gsmolarczyk (Gustaw Smolarczyk) noreply at phabricator.kde.org
Sun Feb 14 20:37:40 UTC 2016


gsmolarczyk added a comment.


  I have tested these changes (btw: I had to compile 5.0 branch instead of master, it's a bit confusing that the newest fixes are firstly introduced on a release branch and then merged into master from time to time).
  
  It indeed fixes the test case, but importing the semantic parent in case it's different from the lexical parent is still not a good idea. Just moving the inner class definition outside of the outer class reintroduces the problem, i.e. the inner class is claimed to be the inheritor of the outer class.
  
  class X { class Y; };
  class X::Y {};
  
  We could remove this importing altogether, with hope that it won't break anything else.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D583

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mwolff, KDevelop, kfunk, gsmolarczyk
Cc: kfunk, olivierjg, mwolff, kdevelop-devel, arrowdodger


More information about the KDevelop-devel mailing list