Review Request 127027: Add support for CXType_FunctionNoProto

[Kevin Funk]

> On Feb. 10, 2016, 12:05 p.m., Aleix Pol Gonzalez wrote:
> > languages/clang/duchain/builder.cpp, line 1259
> > <https://git.reviewboard.kde.org/r/127027/diff/1/?file=443886#file443886line1259>
> >
> >     I wouldn't add this in this case, I understand your premise but we're not doing this anywhere else and wouldn't be consistent.

It's a "function local" define. Undefining it that case is fine. So +1 from my side.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127027/#review92211
-----------------------------------------------------------


On Feb. 10, 2016, 11:19 a.m., Pedro Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127027/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2016, 11:19 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Add support for CXType_FunctionNoProto as having the same behaviour as CXType_FunctionProto.
> Also, undefine a local macro. This doesn't fix any problems, but I believe its a Good Thing to clean up local macros when we're done with them.
> 
> 
> Diffs
> -----
> 
>   languages/clang/duchain/builder.cpp 22d00f0 
> 
> Diff: https://git.reviewboard.kde.org/r/127027/diff/
> 
> 
> Testing
> -------
> 
> I found this by looking at the output of a running kdev session.
> 
> "kdevelop.plugins.clang: Unhandled type: 110"
> 
> Once I added this change, that output disappeared.
> 
> 
> Thanks,
> 
> Pedro Ferreira
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160210/e35d1a47/attachment-0001.html>