Review Request 127027: Add support for CXType_FunctionNoProto
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Feb 10 12:05:04 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127027/#review92211
-----------------------------------------------------------
It would make sense to include a unit test.
languages/clang/duchain/builder.cpp (line 1259)
<https://git.reviewboard.kde.org/r/127027/#comment62901>
I wouldn't add this in this case, I understand your premise but we're not doing this anywhere else and wouldn't be consistent.
- Aleix Pol Gonzalez
On Feb. 10, 2016, 12:19 p.m., Pedro Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127027/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2016, 12:19 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> Add support for CXType_FunctionNoProto as having the same behaviour as CXType_FunctionProto.
> Also, undefine a local macro. This doesn't fix any problems, but I believe its a Good Thing to clean up local macros when we're done with them.
>
>
> Diffs
> -----
>
> languages/clang/duchain/builder.cpp 22d00f0
>
> Diff: https://git.reviewboard.kde.org/r/127027/diff/
>
>
> Testing
> -------
>
> I found this by looking at the output of a running kdev session.
>
> "kdevelop.plugins.clang: Unhandled type: 110"
>
> Once I added this change, that output disappeared.
>
>
> Thanks,
>
> Pedro Ferreira
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160210/cdeeb150/attachment.html>
More information about the KDevelop-devel
mailing list