[Differential] [Accepted] D3842: Type hints from keyword arguments to named parameters.

[brauch (Sven Brauch)]

brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.


  Looks ok and makes sense except for the two remarks. Thanks!

INLINE COMMENTS

> declarationbuilder.cpp:965
> +    }
> +    const int specialParamsCount = (function->vararg() > -1) + (function->kwarg() > -1);
>  

!= instead of > ?

> declarationbuilder.cpp:1061
>      DUChainWriteLocker wlock;
> -    if ( function->kwarg() < 0 || parameters.isEmpty() ) {
> -        // no kwarg, stop here.
> -        return;
> -    }
> +    qWarning() << "Doing keywords";
>      foreach ( KeywordAst* keyword, node->keywords ) {

remove

REPOSITORY
  R53 KDevelop: Python Support

REVISION DETAIL
  https://phabricator.kde.org/D3842

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161228/1821f95b/attachment.html>