<table><tr><td style="">brauch accepted this revision.<br />brauch added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3842" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks ok and makes sense except for the two remarks. Thanks!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3842#inline-15254" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">declarationbuilder.cpp:965</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">specialParamsCount</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">function</span><span style="color: #aa2211">-></span><span class="n">vararg</span><span class="p">()</span> <span style="color: #aa2211">></span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="p">(</span><span class="n">function</span><span style="color: #aa2211">-></span><span class="n">kwarg</span><span class="p">()</span> <span style="color: #aa2211">></span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">!= instead of > ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D3842#inline-15255" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">declarationbuilder.cpp:1061</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">DUChainWriteLocker</span> <span class="n">wlock</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">function</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">kwar</span>g</span><span class="p">()</span> <span style="color: #aa2211"><<span class="bright"></span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span class="n"><span class="bright">parameters</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">isEmpty</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span style="color: #74777d">// no kwarg, stop here.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span style="color: #aa4000">return</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="bright"></span><span class="n"><span class="bright">qWarnin</span>g</span><span class="p">()</span> <span style="color: #aa2211"><<span class="bright"><</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Doing keywords"</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">foreach</span> <span class="p">(</span> <span class="n">KeywordAst</span><span style="color: #aa2211">*</span> <span class="n">keyword</span><span class="p">,</span> <span class="n">node</span><span style="color: #aa2211">-></span><span class="n">keywords</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="n">AbstractType</span><span style="color: #aa2211">::</span><span class="n">Ptr</span> <span class="n">param</span> <span style="color: #aa2211">=</span> <span class="n">parameters</span><span class="p">.</span><span class="n">last</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">abstractType</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span style="color: #aa4000">auto</span> <span class="n">list</span> <span style="color: #aa2211">=</span> <span class="n">param</span><span class="p">.</span><span class="n">cast</span><span style="color: #aa2211"><</span><span class="n">ListType</span><span style="color: #aa2211">></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span style="color: #aa4000">if</span> <span class="p">(</span> <span style="color: #aa2211">!</span> <span class="n">list</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span style="color: #aa4000">continue</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">        <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">remove</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R53 KDevelop: Python Support</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3842" rel="noreferrer">https://phabricator.kde.org/D3842</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>flherne, brauch<br /><strong>Cc: </strong>kdevelop-devel<br /></div>