Review Request 129599: segfault when ruby was not installed
Leslie Zhai
xiangzhai83 at gmail.com
Fri Dec 2 08:43:35 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129599/
-----------------------------------------------------------
(Updated εδΊζ 2, 2016, 4:43 p.m.)
Review request for KDevelop and Kevin Funk.
Changes
-------
Fix as Sven Brauch suggested!
Repository: kdev-ruby
Description
-------
if ruby was not installed, ruby.readAllStandardOutput().split(' ')'s size is ZERO, so I simply added the check:
```
QByteArray allOutput = ruby.readAllStandardOutput();
if (allOutput.split(' ').size() > 1)
```
Diffs (updated)
-----
languagesupport.cpp d618d7d
Diff: https://git.reviewboard.kde.org/r/129599/diff/
Testing
-------
1. Not intalled ruby, kdevelop import redmin (a bug tracker written in ruby) will NOT segfault
2. Installed ruby, the same story
Thanks,
Leslie Zhai
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161202/a88f70bb/attachment.html>
More information about the KDevelop-devel
mailing list