Review Request 129599: segfault when ruby was not installed

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129599/#review101209
-----------------------------------------------------------



Good fix in general, but see inline comment.


languagesupport.cpp (line 72)
<https://git.reviewboard.kde.org/r/129599/#comment67814>

    Do something like this instead:
     auto program = QStandardPaths::findExecutable("ruby")
     if ( !program.isEmpty() ) { ... }
     
    Before you check the size of output.split(' ') put it in a local variable so you don't have to do the check twice.


- Sven Brauch


On Dec. 2, 2016, 5:18 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129599/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 5:18 a.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Repository: kdev-ruby
> 
> 
> Description
> -------
> 
> if ruby was not installed, ruby.readAllStandardOutput().split(' ')'s size is ZERO, so I simply added the check:
> 
> ```
> QByteArray allOutput = ruby.readAllStandardOutput();
> if (allOutput.split(' ').size() > 1)
> ```
> 
> 
> Diffs
> -----
> 
>   languagesupport.cpp d618d7d 
> 
> Diff: https://git.reviewboard.kde.org/r/129599/diff/
> 
> 
> Testing
> -------
> 
> 1. Not intalled ruby, kdevelop import redmin (a bug tracker written in ruby) will NOT segfault
> 2. Installed ruby, the same story
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161202/1793be10/attachment.html>