Small questions about kdev-cppcheck development

[Aleix Pol]

On Mon, Aug 22, 2016 at 1:23 PM, Anton Anikin <anton.anikin at htower.ru> wrote:
> Hello, Kevin.
>
> Thanks for you answers.
>
>>  There's an uncrustify config in kdevplatform and kdevelop you can use [1].
>>  [1] http://uncrustify.sourceforge.net/
>
> Great tool, thanks!
>
> I implemented some of my ideas about kdev-cppcheck and would like to hear your opinion about them:
>
> 1) Is it reasonable to hide by default the output of cppcheck and implement an "on-the-fly" populating of list of detected problems (i.e. Problems view is automatically raised after start and populated during check) with progress bar displaying in the status bar? The output of cppcheck is not deleted and can be viewed in the appropriate outputview.

Sounds reasonable

> 2) Is it reasonable to add cppcheck-related items to context menu for project items?

Be careful, if we can find ways to make it work transparently that
would be best IMHO. We don't want to have entries in the context menu
for every tool on our system.

> 3) Should i "hide" implementation details into Private classes (PIMPL idiom). Many classes of kdevtemplate using this approach.
pimpl should only be used for public API. This is not public API.

> 4) What is the preferred way to do pull-requests - by a set of small patches or by several large ("accumulating")?
We prefer autocontained merged patches.

Aleix