Review Request 128601: Fail early, fail verbosely

Aleix Pol Gonzalez aleixpol at kde.org
Thu Aug 4 17:41:49 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128601/
-----------------------------------------------------------

(Updated Aug. 4, 2016, 1:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Changes
-------

Submitted with commit f1f053547acc0fc95114014c4d83b30c3ce4a8cf by Aleix Pol to branch 5.0.


Repository: kdevplatform


Description
-------

Now we require IndexedStrings to be normalized. This makes my kdevelop crash every now and then.
This helped me debug the issue.


Diffs
-----

  language/editor/documentrange.h 2040456 
  serialization/indexedstring.cpp d4673a8 

Diff: https://git.reviewboard.kde.org/r/128601/diff/


Testing
-------

After this, I could easily fix a crash.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160804/0f4163f0/attachment.html>


More information about the KDevelop-devel mailing list