Review Request 128601: Fail early, fail verbosely

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128601/#review98109
-----------------------------------------------------------


Ship it!




I had a similar patch locally, +1. I'd make the debug into a warning.

- Sven Brauch


On Aug. 4, 2016, 3:17 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128601/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 3:17 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Now we require IndexedStrings to be normalized. This makes my kdevelop crash every now and then.
> This helped me debug the issue.
> 
> 
> Diffs
> -----
> 
>   language/editor/documentrange.h 2040456 
>   serialization/indexedstring.cpp d4673a8 
> 
> Diff: https://git.reviewboard.kde.org/r/128601/diff/
> 
> 
> Testing
> -------
> 
> After this, I could easily fix a crash.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160804/1173c250/attachment.html>