Review Request 128593: Fix wrong tab colors

[Alexander Zhigalin]

> On Авг. 3, 2016, 4:04 п.п., Aleix Pol Gonzalez wrote:
> > Please explain the issue a bit further? Is the problem to use KColorScheme altogether? Is it about the color scheme setting we introduced?
> > How do you test it?

We have a `scheme = new KColorScheme(QPalette palette)`,
`palette` does have the colors inside but only the palette state is being used by `KColorScheme` and the colors are taken from the system configuration.
Until `QApplication::instance()->palette() == defaultPalette` it is OK.
But if someone change the application palette at run-time it breaks.
Like black text on black background.
As there is really no need to use `KColorScheme` there I have just removed it.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128593/#review98059
-----------------------------------------------------------


On Авг. 3, 2016, 3:55 п.п., Alexander Zhigalin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128593/
> -----------------------------------------------------------
> 
> (Updated Авг. 3, 2016, 3:55 п.п.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez and Kevin Funk.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> KColorScheme was somehow ignoring the palette which should be assigned by the constructor and ends up using the system one.
> As we don't really need the KColorScheme functions I have just removed it.
> 
> 
> Diffs
> -----
> 
>   shell/mainwindow.cpp d4ee1a4 
>   util/widgetcolorizer.cpp 68835fd 
> 
> Diff: https://git.reviewboard.kde.org/r/128593/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Zhigalin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160803/318bd5dd/attachment-0001.html>