Review Request 128593: Fix wrong tab colors
Milian Wolff
mail at milianw.de
Wed Aug 3 16:17:58 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128593/#review98062
-----------------------------------------------------------
I actually can imagine that this works. I expect the tabs are still colorized, and that switching between color schemes via the systemsettings KCM is properly updating the tab color now?
- Milian Wolff
On Aug. 3, 2016, 3:55 p.m., Alexander Zhigalin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128593/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2016, 3:55 p.m.)
>
>
> Review request for KDevelop, Aleix Pol Gonzalez and Kevin Funk.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> KColorScheme was somehow ignoring the palette which should be assigned by the constructor and ends up using the system one.
> As we don't really need the KColorScheme functions I have just removed it.
>
>
> Diffs
> -----
>
> shell/mainwindow.cpp d4ee1a4
> util/widgetcolorizer.cpp 68835fd
>
> Diff: https://git.reviewboard.kde.org/r/128593/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Zhigalin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160803/5e488dec/attachment.html>
More information about the KDevelop-devel
mailing list