Review Request 126856: Remove text from documentation find widget's buttons

Igor Kushnir igorkuo at gmail.com
Sun Apr 24 14:53:19 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126856/
-----------------------------------------------------------

(Updated April 24, 2016, 2:53 p.m.)


Review request for KDevelop.


Changes
-------

* Move setting button icons from cpp to ui file.
* Add button text, which is normally overriden by the icon.
* Turn documentation search field's tooltip into placeholder text.

Screenshot: https://drive.google.com/file/d/0B0F-aqLyFk_PQzR5T1Yxb1RMd0k/view?usp=sharing


Repository: kdevplatform


Description
-------

Remove text from documentation find widget's buttons

Screenshots: https://drive.google.com/uc?export=download&id=0B0F-aqLyFk_PRWZnS3dLQ3ZHcTQ
Note that with these changes the top Documentation Tool Bar requires more horizontal space than the documentation find widget. I proposed a solution { split the top toolbar in two rows } in https://git.reviewboard.kde.org/r/126685/ (see links to screenshots in my recent comments).


Diffs (updated)
-----

  documentation/documentationfindwidget.cpp 6bf24ab6ecf52d733d13bfae9a459230dab5ca40 
  documentation/documentationfindwidget.ui ce07311f2c89be70c45bf796a76177c0614cabd4 

Diff: https://git.reviewboard.kde.org/r/126856/diff/


Testing
-------

Built, installed, tested both with and without documentation zoom implementation.


Thanks,

Igor Kushnir

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160424/5f073cbb/attachment.html>


More information about the KDevelop-devel mailing list