Review Request 126856: Remove text from documentation find widget's buttons

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126856/#review94807
-----------------------------------------------------------




documentation/documentationfindwidget.ui (line 50)
<https://git.reviewboard.kde.org/r/126856/#comment64412>

    can't you use the "placeholderText" property for that?
    
    http://doc.qt.io/qt-5/qlineedit.html#placeholderText-prop



documentation/documentationfindwidget.ui (line 61)
<https://git.reviewboard.kde.org/r/126856/#comment64413>

    I don't think that "..." is a good text for a button, esp. if it's repeated below. can you keep it as is and add an icon and show that instead of the text by default?


- Milian Wolff


On April 16, 2016, 7:25 p.m., Igor Kushnir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126856/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 7:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Remove text from documentation find widget's buttons
> 
> Screenshots: https://drive.google.com/uc?export=download&id=0B0F-aqLyFk_PRWZnS3dLQ3ZHcTQ
> Note that with these changes the top Documentation Tool Bar requires more horizontal space than the documentation find widget. I proposed a solution { split the top toolbar in two rows } in https://git.reviewboard.kde.org/r/126685/ (see links to screenshots in my recent comments).
> 
> 
> Diffs
> -----
> 
>   documentation/documentationfindwidget.cpp 6bf24ab6ecf52d733d13bfae9a459230dab5ca40 
>   documentation/documentationfindwidget.ui ce07311f2c89be70c45bf796a76177c0614cabd4 
> 
> Diff: https://git.reviewboard.kde.org/r/126856/diff/
> 
> 
> Testing
> -------
> 
> Built, installed, tested both with and without documentation zoom implementation.
> 
> 
> Thanks,
> 
> Igor Kushnir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160424/6ff820c7/attachment.html>