Review Request 125447: IVariableController: return KTE::Range of expression instead of its text.

Maciej Cencora m.cencora at gmail.com
Tue Sep 29 14:04:44 UTC 2015



> On Wrz 29, 2015, 12:50 po poĊ‚udniu, Aleix Pol Gonzalez wrote:
> > I don't really see what you're fixing here, you're just delaying the text extraction, no?

Yes, this patch only lays ground for the actual fix.

Tooltip flickering fix needs the Range of the text given tooltip is to be shown for (in order not to hide tooltip when mouse is inside this area), not the text itself.


- Maciej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125447/#review86105
-----------------------------------------------------------


On Wrz 29, 2015, 9:55 rano, Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125447/
> -----------------------------------------------------------
> 
> (Updated Wrz 29, 2015, 9:55 rano)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This is needed to fixup flickering in debug view navigation tooltips.
> 
> I'll create seperate review request for actual fix, but I cannot do it before this gets committed.
> 
> 
> Diffs
> -----
> 
>   debugger/interfaces/ivariablecontroller.h 9303af0 
>   debugger/variable/variablecollection.cpp 703f0ec 
> 
> Diff: https://git.reviewboard.kde.org/r/125447/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150929/783891f2/attachment.html>


More information about the KDevelop-devel mailing list