Review Request 125447: IVariableController: return KTE::Range of expression instead of its text.

Aleix Pol Gonzalez aleixpol at kde.org
Tue Sep 29 12:50:24 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125447/#review86105
-----------------------------------------------------------


I don't really see what you're fixing here, you're just delaying the text extraction, no?

- Aleix Pol Gonzalez


On Sept. 29, 2015, 11:55 a.m., Maciej Cencora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125447/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 11:55 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This is needed to fixup flickering in debug view navigation tooltips.
> 
> I'll create seperate review request for actual fix, but I cannot do it before this gets committed.
> 
> 
> Diffs
> -----
> 
>   debugger/interfaces/ivariablecontroller.h 9303af0 
>   debugger/variable/variablecollection.cpp 703f0ec 
> 
> Diff: https://git.reviewboard.kde.org/r/125447/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Maciej Cencora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150929/528f58ae/attachment.html>


More information about the KDevelop-devel mailing list