Review Request 125301: Don't show explicitly deleted/default functions in implements completion

Alex Richardson arichardson.kde at
Sat Sep 19 18:38:17 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 19, 2015, 7:38 p.m.)

Review request for KDevelop.


Use Sergeys suggested approach instead.
While I was at it also added a RAII class for clang_tokenize (which also fixes two memory leaks due to missing clang_disposeTokens() call)

Repository: kdev-clang


REVIEW: 125301

Diffs (updated)

  codecompletion/completionhelper.cpp df5712bb31dfa39e99a593367036d42dc41701d1 
  codecompletion/context.cpp 995b4b04157be9658e651c1680f3c0222cb0d8b0 
  duchain/clangproblem.cpp bd5a20105c1c3769791f75389afbdc93a5b9c193 
  duchain/todoextractor.cpp 764fbd251e028df85844f98ca851a4422406d163 
  tests/clang-parser.cpp 27b4eb535f3f47e84a495daaa60862257170f1fa 
  tests/test_codecompletion.cpp a2ed37f55995a8d224512d59b187dba1a80ed446 
  util/clangtypes.h 1913e444ff021b5ba3fc4a5cf555ed19e4460646 
  util/clangutils.h af80b906eb1ca466f110c8c12637568ab1a52fc4 
  util/clangutils.cpp 506dfdeeeccf4d665a53d0b1ebaaa608a7ec9cb5 



Tests pass except for the global deleted function.

Not sure how to fix this as it seems like clang_getCursorExtent(declCursor) is wrong in that case. Or maybe I need to calaculate the range differently?


Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list