Review Request 125301: Don't show explicitly deleted/default functions in implements completion

[Alex Richardson]

> On Sept. 19, 2015, 4:50 p.m., Sergey Kalinichev wrote:
> > util/clangutils.cpp, line 293
> > <https://git.reviewboard.kde.org/r/125301/diff/2/?file=404710#file404710line293>
> >
> >     Wouldn't it be easier to process tokens from the end, it could probably simplify the code a bit?

Good idea! I think then we can stop searching once we find the first closing parenthesis.

All these cases do not compile:

```
    void foo(bool) = (delete);
    void foo(double) (= delete);
    void foo(char) (=) delete;
```

Am I missing something or is stopping the iteration once we find a closing parenthesis okay?


> On Sept. 19, 2015, 4:50 p.m., Sergey Kalinichev wrote:
> > util/clangutils.cpp, line 289
> > <https://git.reviewboard.kde.org/r/125301/diff/2/?file=404710#file404710line289>
> >
> >     Can we add a test for it?

Can be dropped if we iterate backwards


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125301/#review85669
-----------------------------------------------------------


On Sept. 19, 2015, 2:11 a.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125301/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2015, 2:11 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> REVIEW: 125301
> 
> 
> Diffs
> -----
> 
>   util/clangutils.cpp 506dfdeeeccf4d665a53d0b1ebaaa608a7ec9cb5 
>   tests/test_codecompletion.cpp a2ed37f55995a8d224512d59b187dba1a80ed446 
>   util/clangutils.h af80b906eb1ca466f110c8c12637568ab1a52fc4 
>   codecompletion/completionhelper.cpp df5712bb31dfa39e99a593367036d42dc41701d1 
> 
> Diff: https://git.reviewboard.kde.org/r/125301/diff/
> 
> 
> Testing
> -------
> 
> Tests pass except for the global deleted function.
> 
> Not sure how to fix this as it seems like clang_getCursorExtent(declCursor) is wrong in that case. Or maybe I need to calaculate the range differently?
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150919/5ed4dd13/attachment-0001.html>