Review Request 124969: Show popup menu with overriden methods when clicking on virtual function declaration

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124969/#review84686
-----------------------------------------------------------


Hmm, for me it seems like you're trying to reimplement some functionality from the navigation widget that we already have: switching between declaration <-> definition and navigation on overriden and hiden functions. (See also AbstractDeclarationNavigationContext::htmlAdditionalNavigation). 
So, I'd prefer if we could extend/fix it's functionality there, instead of duplicating it.

- Sergey Kalinichev


On Aug. 28, 2015, 9:28 p.m., Oleksandr Senkovych wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124969/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 9:28 p.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Items are sorted in a following order:
> 1. Link to function definition
> 2. Link to a declaration of a base class
> 3. Alphabetically sorted all possible overrides of a method
> 
> 
> Diffs
> -----
> 
>   plugins/contextbrowser/browsemanager.h ca6461a 
>   plugins/contextbrowser/browsemanager.cpp 2574559 
> 
> Diff: https://git.reviewboard.kde.org/r/124969/diff/
> 
> 
> Testing
> -------
> 
> Currently there's two unresolved issues with it:
> 1. If there's too much possible overloads - menu will eat all the space on a screen.
> 2. maxAllowedSteps parameter is UINT_MAX, so there could be some freezes depending on project complexity. I don't have them on my machine when showing items for a really big project (clang parses it for 2-3 hours).
> 
> 
> Thanks,
> 
> Oleksandr Senkovych
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150901/8c7b4268/attachment.html>