<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124969/">https://git.reviewboard.kde.org/r/124969/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmm, for me it seems like you're trying to reimplement some functionality from the navigation widget that we already have: switching between declaration <-> definition and navigation on overriden and hiden functions. (See also AbstractDeclarationNavigationContext::htmlAdditionalNavigation).
So, I'd prefer if we could extend/fix it's functionality there, instead of duplicating it.</p></pre>
<br />
<p>- Sergey Kalinichev</p>
<br />
<p>On August 28th, 2015, 9:28 p.m. MSK, Oleksandr Senkovych wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Kevin Funk.</div>
<div>By Oleksandr Senkovych.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2015, 9:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Items are sorted in a following order:
1. Link to function definition
2. Link to a declaration of a base class
3. Alphabetically sorted all possible overrides of a method</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently there's two unresolved issues with it:
1. If there's too much possible overloads - menu will eat all the space on a screen.
2. maxAllowedSteps parameter is UINT_MAX, so there could be some freezes depending on project complexity. I don't have them on my machine when showing items for a really big project (clang parses it for 2-3 hours).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/contextbrowser/browsemanager.h <span style="color: grey">(ca6461a)</span></li>
<li>plugins/contextbrowser/browsemanager.cpp <span style="color: grey">(2574559)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124969/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>