Review Request 125549: using qsortfilterproxy model to sort the variables

Vladimir Prus vladimir.prus at gmail.com
Thu Oct 22 07:07:48 UTC 2015


On 14-Oct-15 10:00 PM, Sven Brauch wrote:
> This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125549/
>
>
>     On October 14th, 2015, 6:45 p.m. UTC, *Vladimir Prus* wrote:
>
>         debugger/util/treeview.cpp <https://git.reviewboard.kde.org/r/125549/diff/3/?file=411021#file411021line35> (Diff
>         revision 3)
>         	
>
>         	34 	
>
>              setSortingEnabled(true);
>
>         Hold on, so we now /always/ sort, with no way to control that behaviour? Does not seem very good, maybe the
>         proxy should not really be constructed here, but in variables widget?
>
> In which casedo you want the list of variables to be randomly sorted instead of alphabetically?

Sven,

treeview.cpp is not a list of variables, it's a generic tree view. It's reasonable to have variables sorted by default, 
but it better be done in variables widget then.


- Volodya




More information about the KDevelop-devel mailing list