Review Request 125549: using qsortfilterproxy model to sort the variables

Sven Brauch mail at svenbrauch.de
Wed Oct 14 19:00:34 UTC 2015



> On Oct. 14, 2015, 6:45 p.m., Vladimir Prus wrote:
> > debugger/util/treeview.cpp, line 35
> > <https://git.reviewboard.kde.org/r/125549/diff/3/?file=411021#file411021line35>
> >
> >     Hold on, so we now *always* sort, with no way to control that behaviour? Does not seem very good, maybe the proxy should not really be constructed here, but in variables widget?

In which case do you want the list of variables to be randomly sorted instead of alphabetically?


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125549/#review86857
-----------------------------------------------------------


On Oct. 14, 2015, 12:55 p.m., rishabh  gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125549/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 12:55 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Bugs: 119929
>     http://bugs.kde.org/show_bug.cgi?id=119929
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> bug 119929 .sorting varibales list alphabetically using qsortfilterproxymodel
> 
> 
> Diffs
> -----
> 
>   debugger/util/treeitem.h ec652c9 
>   debugger/util/treeitem.cpp 45cd081 
>   debugger/util/treemodel.h f121b56 
>   debugger/util/treemodel.cpp 9a7cafa 
>   debugger/util/treeview.h f6a6370 
>   debugger/util/treeview.cpp ae9f0e0 
>   debugger/variable/variablewidget.cpp 79f366d 
> 
> Diff: https://git.reviewboard.kde.org/r/125549/diff/
> 
> 
> Testing
> -------
> 
> built
> 
> testing done
> 
> 
> Thanks,
> 
> rishabh  gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151014/b6cc4033/attachment.html>


More information about the KDevelop-devel mailing list