Review Request 125549: using qsortfilterproxy model to sort the variables

[Vladimir Prus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125549/#review86843
-----------------------------------------------------------


This seem generally fine to me, as far as TreeItem/TreeModel go. I've made a few suggestions that you might want to consider. Thanks!


debugger/util/treeitem.h (line 43)
<https://git.reviewboard.kde.org/r/125549/#comment59729>

    Spurious formatting change.



debugger/util/treeitem.cpp (line 171)
<https://git.reviewboard.kde.org/r/125549/#comment59730>

    Spuriois whitespace change.



debugger/util/treemodel.h (line 52)
<https://git.reviewboard.kde.org/r/125549/#comment59735>

    I'd prefer this definition to be towards the top of the class.



debugger/util/treeview.h 
<https://git.reviewboard.kde.org/r/125549/#comment59732>

    Another one



debugger/util/treeview.h (line 50)
<https://git.reviewboard.kde.org/r/125549/#comment59733>

    Another one.



debugger/variable/variablewidget.cpp (line 251)
<https://git.reviewboard.kde.org/r/125549/#comment59734>

    Do we need KDevelop:: here? We're already inside KDevelop namespace and don't qualify other names.


- Vladimir Prus


On Oct. 14, 2015, 12:55 p.m., rishabh  gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125549/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 12:55 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Bugs: 119929
>     http://bugs.kde.org/show_bug.cgi?id=119929
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> bug 119929 .sorting varibales list alphabetically using qsortfilterproxymodel
> 
> 
> Diffs
> -----
> 
>   debugger/util/treeitem.h ec652c9 
>   debugger/util/treeitem.cpp 45cd081 
>   debugger/util/treemodel.h f121b56 
>   debugger/util/treemodel.cpp 9a7cafa 
>   debugger/util/treeview.h f6a6370 
>   debugger/util/treeview.cpp ae9f0e0 
>   debugger/variable/variablewidget.cpp 79f366d 
> 
> Diff: https://git.reviewboard.kde.org/r/125549/diff/
> 
> 
> Testing
> -------
> 
> built
> 
> testing done
> 
> 
> Thanks,
> 
> rishabh  gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151014/cff65c23/attachment.html>