Review Request 125600: do not start completion _everywhere_ at random

[Sven Brauch]

> On Oct. 12, 2015, 9:18 a.m., Milian Wolff wrote:
> > languages/clang/codecompletion/model.cpp, line 174
> > <https://git.reviewboard.kde.org/r/125600/diff/1/?file=410637#file410637line174>
> >
> >     space is fine, no?
> >     
> >     
> >         foo(asdf, |)

It's fine, but not enough for automatic invocation imo. It will anyways invoke the widget automatically after you start typing some name or so. I think automatic completion should be reserved for e.g. member access or so where there's really specific set of suggestions to make.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125600/#review86697
-----------------------------------------------------------


On Oct. 12, 2015, 9:10 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125600/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 9:10 a.m.)
> 
> 
> Review request for KDevelop, Milian Wolff and Olivier de Gaalon.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This can certainly be improved but it's certainly better than nothing; at least it doesn't start after a ; any more or similar nonsense
> 
> 
> Diffs
> -----
> 
>   languages/clang/codecompletion/model.h 4242aa3 
>   languages/clang/codecompletion/model.cpp 3777b8b 
> 
> Diff: https://git.reviewboard.kde.org/r/125600/diff/
> 
> 
> Testing
> -------
> 
> typed around a bit
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151012/f1b90648/attachment-0001.html>