Review Request 125600: do not start completion _everywhere_ at random

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125600/#review86697
-----------------------------------------------------------

Ship it!


two small nitpicks


languages/clang/codecompletion/model.cpp (line 171)
<https://git.reviewboard.kde.org/r/125600/#comment59672>

    instead of .trimmed().isEmpty() add a `isSpaceOnly` function or similar, which can be implemented by a simple
    
        bool isSpaceOnly(const QString& string)
        {
            return std::find_if(string.begin(), string.end(), [] (const QChar c) { return !c.isSpace(); }) == string.end();
        }
    
    why you may ask? Because .trimmed() would allocate if the string starts/ends with space(s).



languages/clang/codecompletion/model.cpp (line 174)
<https://git.reviewboard.kde.org/r/125600/#comment59671>

    space is fine, no?
    
        foo(asdf, |)


- Milian Wolff


On Oct. 12, 2015, 9:10 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125600/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 9:10 a.m.)
> 
> 
> Review request for KDevelop, Milian Wolff and Olivier de Gaalon.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This can certainly be improved but it's certainly better than nothing; at least it doesn't start after a ; any more or similar nonsense
> 
> 
> Diffs
> -----
> 
>   languages/clang/codecompletion/model.h 4242aa3 
>   languages/clang/codecompletion/model.cpp 3777b8b 
> 
> Diff: https://git.reviewboard.kde.org/r/125600/diff/
> 
> 
> Testing
> -------
> 
> typed around a bit
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151012/d863ea15/attachment.html>