Review Request 125549: using qsortfilterproxy model to sort the variables

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125549/#review86504
-----------------------------------------------------------



debugger/variable/variablewidget.cpp (line 250)
<https://git.reviewboard.kde.org/r/125549/#comment59584>

    it is better because the pattern I showed you is generic. it will work independently of the number of proxies in the middle. it just uses the architecture to bubble up the proxy chain as needed and then returns the data you requested. Much nicer than manually mapping.


- Milian Wolff


On Oct. 8, 2015, 11:34 a.m., rishabh  gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125549/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 11:34 a.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Bugs: 119929
>     http://bugs.kde.org/show_bug.cgi?id=119929
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> bug 119929 .sorting varibales list alphabetically using qsortfilterproxymodel
> 
> 
> Diffs
> -----
> 
>   debugger/variable/variablewidget.cpp 79f366d 
>   debugger/util/treeview.cpp ae9f0e0 
>   debugger/util/treeview.h f6a6370 
> 
> Diff: https://git.reviewboard.kde.org/r/125549/diff/
> 
> 
> Testing
> -------
> 
> built
> 
> testing done
> 
> 
> Thanks,
> 
> rishabh  gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151008/8582ee80/attachment-0001.html>