<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125549/">https://git.reviewboard.kde.org/r/125549/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125549/diff/1/?file=410234#file410234line250" style="color: black; font-weight: bold; text-decoration: underline;">debugger/variable/variablewidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void VariableTree::setupActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">250</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">TreeItem</span><span class="o">*</span> <span class="n">item</span> <span class="o">=</span> <span class="n">collection</span><span class="p">()</span><span class="o">-></span><span class="n">itemForIndex</span><span class="p">(</span><span class="n">selectionModel</span><span class="p">()</span><span class="o">-></span><span class="n">selectedRows</span><span class="p">().</span><span class="n">first</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">250</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">TreeItem</span><span class="o">*</span> <span class="n">item</span> <span class="o">=</span> <span class="n">collection</span><span class="p">()</span><span class="o">-></span><span class="n">itemForIndex</span><span class="p">(</span><span class="n"><span class="hl">proxymodel</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">mapToSource</span></span><span class="p"><span class="hl">(</span></span><span class="n">selectionModel</span><span class="p">()</span><span class="o">-></span><span class="n">selectedRows</span><span class="p">().</span><span class="n">first</span><span class="p">())<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it is better because the pattern I showed you is generic. it will work independently of the number of proxies in the middle. it just uses the architecture to bubble up the proxy chain as needed and then returns the data you requested. Much nicer than manually mapping.</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On October 8th, 2015, 11:34 a.m. UTC, rishabh gupta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Milian Wolff.</div>
<div>By rishabh gupta.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2015, 11:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=119929">119929</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">bug 119929 .sorting varibales list alphabetically using qsortfilterproxymodel</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">built</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">testing done</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debugger/variable/variablewidget.cpp <span style="color: grey">(79f366d)</span></li>
<li>debugger/util/treeview.cpp <span style="color: grey">(ae9f0e0)</span></li>
<li>debugger/util/treeview.h <span style="color: grey">(f6a6370)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125549/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>