Review Request 125549: using qsortfilterproxy model to sort the variables

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125549/#review86484
-----------------------------------------------------------



debugger/variable/variablewidget.cpp (line 174)
<https://git.reviewboard.kde.org/r/125549/#comment59572>

    I think you have to static_cast to a QSortFilterProxyModel here and then return its sourceModel() cast to a VariableCollection instead. This looks wrong.


- Sven Brauch


On Oct. 7, 2015, 6:26 p.m., rishabh  gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125549/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 6:26 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Bugs: 119929
>     http://bugs.kde.org/show_bug.cgi?id=119929
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> bug 119929 .sorting varibales list alphabetically using qsortfilterproxymodel
> 
> 
> Diffs
> -----
> 
>   debugger/util/treeview.h f6a6370 
>   debugger/util/treeview.cpp ae9f0e0 
>   debugger/variable/variablewidget.cpp 79f366d 
> 
> Diff: https://git.reviewboard.kde.org/r/125549/diff/
> 
> 
> Testing
> -------
> 
> built
> 
> works fine if Q_ASSERT(qobject_cast<VariableCollection*>(model())) of variablewidget.cpp line 174 is commented out ,gives SIGABRT otherwise. Is it fine to comment it out ?
> 
> 
> Thanks,
> 
> rishabh  gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151008/4321f299/attachment-0001.html>