[Differential] [Commented On] D564: fix crash on navigation crash, when clicking on '__1' container of clang's libc++ std::__1::string
amccann (Andrew McCann)
noreply at phabricator.kde.org
Mon Nov 23 20:48:12 UTC 2015
amccann added inline comments.
INLINE COMMENTS
language/duchain/navigation/abstractnavigationcontext.cpp:234-236 ```return {};```
has the same effect as
```return NavigationContextPointer(this);```
That said, the original author always used the latter in other contexts in the calling function, so I am sticking with the same pattern.
As for the behavior, it simply doesn't crash now. Clicking the "__1" has no effect now.
REPOSITORY
rKDEVPLATFORM KDevPlatform
BRANCH
fix_navigation_crash
REVISION DETAIL
https://phabricator.kde.org/D564
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: amccann, mwolff, KDevelop
Cc: kdevelop-devel, arrowdodger
More information about the KDevelop-devel
mailing list