[Differential] [Accepted] D564: fix crash on navigation crash, when clicking on '__1' container of clang's libc++ std::__1::string

mwolff (Milian Wolff) noreply at phabricator.kde.org
Sun Nov 22 18:54:13 UTC 2015


mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.

lgtm as a hotfix


INLINE COMMENTS
  language/duchain/navigation/abstractnavigationcontext.cpp:227 could we maybe fix this for real? the code is evil indeed... maybe something for the future though
  language/duchain/navigation/abstractnavigationcontext.cpp:234-236 phew - good question. is the behavior in the case where it crashed before OK now? what happens when you `return {};`?

REPOSITORY
  rKDEVPLATFORM KDevPlatform

BRANCH
  fix_navigation_crash

REVISION DETAIL
  https://phabricator.kde.org/D564

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: amccann, mwolff, KDevelop
Cc: kdevelop-devel, arrowdodger


More information about the KDevelop-devel mailing list