Review Request 123835: handle defined

Zhang HuiJie yitianbuji at gmail.com
Mon May 18 16:04:44 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123835/
-----------------------------------------------------------

(Updated May 18, 2015, 4:04 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Changes
-------

Submitted with commit 35141045dd0583a840576faa51ad20907f369d93 by Milian Wolff on behalf of Zhang HuiJie to branch 4.7.


Repository: kdevelop


Description
-------

The special operator defined is used in ‘#if’ and ‘#elif’ expressions to test whether a certain name is defined as a macro. The origin imp of cpp just ignore it, and will get wrong results in some cases. With this patch, it will work better ^_^.


Diffs
-----

  languages/cpp/parser/rpp/pp-engine.cpp d8fc81d 
  languages/cpp/parser/rpp/pp-macro-expander.h c1887a0 
  languages/cpp/parser/rpp/pp-macro-expander.cpp 59c8385 
  languages/cpp/parser/tests/test_parser.cpp 775ce88 

Diff: https://git.reviewboard.kde.org/r/123835/diff/


Testing
-------

2 tests added and passed. My local copy has run with this patch for days.


Thanks,

Zhang HuiJie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150518/241b6845/attachment.html>


More information about the KDevelop-devel mailing list