Review Request 123835: handle defined

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123835/#review80581
-----------------------------------------------------------

Ship it!


looks good to me - thanks! I'll resolve the issue and push it upstream.


languages/cpp/parser/rpp/pp-macro-expander.cpp (line 375)
<https://git.reviewboard.kde.org/r/123835/#comment55244>

    you could use QByteArray::number directly here


- Milian Wolff


On May 18, 2015, 10:50 a.m., Zhang HuiJie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123835/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 10:50 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> The special operator defined is used in ‘#if’ and ‘#elif’ expressions to test whether a certain name is defined as a macro. The origin imp of cpp just ignore it, and will get wrong results in some cases. With this patch, it will work better ^_^.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/rpp/pp-engine.cpp d8fc81d 
>   languages/cpp/parser/rpp/pp-macro-expander.h c1887a0 
>   languages/cpp/parser/rpp/pp-macro-expander.cpp 59c8385 
>   languages/cpp/parser/tests/test_parser.cpp 775ce88 
> 
> Diff: https://git.reviewboard.kde.org/r/123835/diff/
> 
> 
> Testing
> -------
> 
> 2 tests added and passed. My local copy has run with this patch for days.
> 
> 
> Thanks,
> 
> Zhang HuiJie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150518/037c603b/attachment.html>