Review Request 123715: Enable highlighting of declarations/uses in the DUContext::Other contexts

Milian Wolff mail at milianw.de
Mon May 11 09:23:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123715/#review80208
-----------------------------------------------------------


will this add rainbow colors for global declarations or namespace declarations? that should not happen (we never did that in oldcpp). so maybe its enough to do it only for ::Function type contexts?

- Milian Wolff


On May 10, 2015, 3:01 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123715/
> -----------------------------------------------------------
> 
> (Updated May 10, 2015, 3:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> The highlighting code in kdevplatform expects that the DUContext::Other contexts are owned by the declarations, but this is not the case for the kdev-clang, as we don't use internalFunctionContext's and set DUContext::Function contexts as internalContexts instead.
> 
> 
> Diffs
> -----
> 
>   clanghighlighting.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123715/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150511/d9325311/attachment.html>


More information about the KDevelop-devel mailing list