Review Request 123715: Enable highlighting of declarations/uses in the DUContext::Other contexts

[Kevin Funk]

> On May 10, 2015, 3:30 p.m., Olivier Jean de Gaalon wrote:
> > I like rainbow colors even more than the next guy, so I'm in favor of this. This is a change from the oldcpp which doesn't use it in children of the internalFunctionContext, but maybe someone else should weigh in on if changing that might be an issue (or why it was that way)

I don't see an issue with this change. We only create contexts with type `DUContext::Other` for macro definitions and compound statements afaics. Macro definitions' contents are not duchainified, so that leaves compound statements where rainbow coloring is wanted.

Let's wait for Milian for a clear +1.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123715/#review80173
-----------------------------------------------------------


On May 10, 2015, 3:01 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123715/
> -----------------------------------------------------------
> 
> (Updated May 10, 2015, 3:01 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> The highlighting code in kdevplatform expects that the DUContext::Other contexts are owned by the declarations, but this is not the case for the kdev-clang, as we don't use internalFunctionContext's and set DUContext::Function contexts as internalContexts instead.
> 
> 
> Diffs
> -----
> 
>   clanghighlighting.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123715/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150511/b36157ca/attachment.html>