Review Request 123093: Port away from KIO::NetAccess

[Dāvis Mosāns]

> On marts 21, 2015, 6:13 p.m., Aleix Pol Gonzalez wrote:
> > Good patch. It's mostly about figuring out includes though. When committing, can you do so separately?

Seperate in 2 commits like one with implementation porting and other with just header changes? or more detailed like for each plugin? and yeah sure.


- Dāvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123093/#review77886
-----------------------------------------------------------


On marts 21, 2015, 7:27 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123093/
> -----------------------------------------------------------
> 
> (Updated marts 21, 2015, 7:27 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Port away from KIO::NetAccess
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/appwizarddialog.h 2d781b18436cdb876753f3cb840b2dacafcebeca 
>   plugins/appwizard/appwizardplugin.cpp 0986da015637c0e36bbe84fd79f3ab503a5eff33 
>   plugins/appwizard/projectselectionpage.h 4fba704b3d26ddd51055baf46eb9240d503175f6 
>   plugins/appwizard/projectselectionpage.cpp 167f0b23cb3258dcab59577b40a5d55160725635 
>   plugins/appwizard/projecttemplatesmodel.cpp 9b51dc123c1847ba3620ca0ad61cb36f7e7c94f9 
>   plugins/appwizard/projectvcspage.cpp 2127caf7697ebdc7f92b11a07100d86098e63343 
>   plugins/patchreview/localpatchsource.cpp 65c6fb6b7e4f6176213ab803d18a8ed05fe560b8 
>   plugins/patchreview/patchhighlighter.cpp 77313596babb2fc3a1934ba0e8c6b14ff02d3253 
>   plugins/patchreview/patchreview.cpp 72b7f9ecf9315cd2f6690550c723f9a1fb001868 
>   plugins/patchreview/patchreviewtoolview.cpp 17e63be67244a02d5804c7e0d97e0138848bc163 
>   plugins/patchreview/standardpatchexport.cpp 110cde0a16446368c02bfb9ba803b6c5e79ee372 
>   shell/tests/test_plugincontroller.cpp 4055a8b12b8f8792a2aa1dabee5776ef7bc979ad 
>   shell/tests/test_projectcontroller.cpp fd630c3a375a3e61da6650bcbd47f34ed6826c95 
>   shell/tests/test_sessioncontroller.cpp b484c928adab967d50f6a8fdf69577088dab227e 
> 
> Diff: https://git.reviewboard.kde.org/r/123093/diff/
> 
> 
> Testing
> -------
> 
> Compiles.
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150321/137b75ba/attachment.html>