<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123093/">https://git.reviewboard.kde.org/r/123093/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On marts 21st, 2015, 6:13 p.m. EET, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good patch. It's mostly about figuring out includes though. When committing, can you do so separately?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seperate in 2 commits like one with implementation porting and other with just header changes? or more detailed like for each plugin? and yeah sure.</p></pre>
<br />
<p>- Dāvis</p>
<br />
<p>On marts 21st, 2015, 7:27 a.m. EET, Dāvis Mosāns wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dāvis Mosāns.</div>
<p style="color: grey;"><i>Updated marts 21, 2015, 7:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port away from KIO::NetAccess</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/appwizard/appwizarddialog.h <span style="color: grey">(2d781b18436cdb876753f3cb840b2dacafcebeca)</span></li>
<li>plugins/appwizard/appwizardplugin.cpp <span style="color: grey">(0986da015637c0e36bbe84fd79f3ab503a5eff33)</span></li>
<li>plugins/appwizard/projectselectionpage.h <span style="color: grey">(4fba704b3d26ddd51055baf46eb9240d503175f6)</span></li>
<li>plugins/appwizard/projectselectionpage.cpp <span style="color: grey">(167f0b23cb3258dcab59577b40a5d55160725635)</span></li>
<li>plugins/appwizard/projecttemplatesmodel.cpp <span style="color: grey">(9b51dc123c1847ba3620ca0ad61cb36f7e7c94f9)</span></li>
<li>plugins/appwizard/projectvcspage.cpp <span style="color: grey">(2127caf7697ebdc7f92b11a07100d86098e63343)</span></li>
<li>plugins/patchreview/localpatchsource.cpp <span style="color: grey">(65c6fb6b7e4f6176213ab803d18a8ed05fe560b8)</span></li>
<li>plugins/patchreview/patchhighlighter.cpp <span style="color: grey">(77313596babb2fc3a1934ba0e8c6b14ff02d3253)</span></li>
<li>plugins/patchreview/patchreview.cpp <span style="color: grey">(72b7f9ecf9315cd2f6690550c723f9a1fb001868)</span></li>
<li>plugins/patchreview/patchreviewtoolview.cpp <span style="color: grey">(17e63be67244a02d5804c7e0d97e0138848bc163)</span></li>
<li>plugins/patchreview/standardpatchexport.cpp <span style="color: grey">(110cde0a16446368c02bfb9ba803b6c5e79ee372)</span></li>
<li>shell/tests/test_plugincontroller.cpp <span style="color: grey">(4055a8b12b8f8792a2aa1dabee5776ef7bc979ad)</span></li>
<li>shell/tests/test_projectcontroller.cpp <span style="color: grey">(fd630c3a375a3e61da6650bcbd47f34ed6826c95)</span></li>
<li>shell/tests/test_sessioncontroller.cpp <span style="color: grey">(b484c928adab967d50f6a8fdf69577088dab227e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123093/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>