Review Request 122840: custom-definesandincludes: don't crash on the configuration after pressing Apply

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122840/#review77099
-----------------------------------------------------------


Given the code I'd say its a missing initialization of the path.compiler member, thats most likely a bug elsewhere. If it is intended to be null I'd still place the check at the callsite of the writeToConfig function and thus keep the assert.

- Andreas Pakulat


On March 6, 2015, 8:44 a.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122840/
> -----------------------------------------------------------
> 
> (Updated March 6, 2015, 8:44 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> I haven't touched the "Compilers" tab, so maybe this is why I'm getting this assert all the time. In this patch I've replaced the assert with a good ol'
> 
> ```cpp
> if (!compiler) {
> ```
> 
> Since this is an assert, I wanted to check this here first before pushing or anything :)
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp df2c425 
> 
> Diff: https://git.reviewboard.kde.org/r/122840/diff/
> 
> 
> Testing
> -------
> 
> manual testing
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150306/3734cf31/attachment.html>