Review Request 122840: custom-definesandincludes: don't crash on the configuration after pressing Apply

Miquel Sabaté Solà mikisabate at
Fri Mar 6 08:44:37 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for KDevelop.

Repository: kdevelop


I haven't touched the "Compilers" tab, so maybe this is why I'm getting this assert all the time. In this patch I've replaced the assert with a good ol'

if (!compiler) {

Since this is an assert, I wanted to check this here first before pushing or anything :)


  languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp df2c425 



manual testing


Miquel Sabaté Solà

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list