Review Request 122840: custom-definesandincludes: don't crash on the configuration after pressing Apply

Miquel Sabaté Solà mikisabate at gmail.com
Fri Mar 6 08:44:37 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122840/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdevelop


Description
-------

I haven't touched the "Compilers" tab, so maybe this is why I'm getting this assert all the time. In this patch I've replaced the assert with a good ol'

```cpp
if (!compiler) {
```

Since this is an assert, I wanted to check this here first before pushing or anything :)


Diffs
-----

  languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp df2c425 

Diff: https://git.reviewboard.kde.org/r/122840/diff/


Testing
-------

manual testing


Thanks,

Miquel Sabaté Solà

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150306/623bdf23/attachment.html>


More information about the KDevelop-devel mailing list